On Thu, Mar 14, 2019 at 10:14:12AM +0000, Biju Das wrote: > Hi Shimoda-San, > > Thanks for the feedback. > > > Subject: RE: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role- > > switch property > > > > Hi Biju-san, > > > > > From: Biju Das, Sent: Thursday, March 14, 2019 5:40 PM > > > > > > Add support for renesas_usb3 to support dual role switch using usb > > > role switch class framework. > > > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > > --- > > > V1-->V2 > > > * Added usb-role-switch-property > > > * Updated the example with usb-role-switch property. > > > --- > > > .../devicetree/bindings/usb/renesas_usb3.txt | 22 > > ++++++++++++++++++++++ > > > 1 file changed, 22 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > index 35039e7..eecaf4c 100644 > > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > @@ -22,6 +22,7 @@ Required properties: > > > Optional properties: > > > - phys: phandle + phy specifier pair > > > - phy-names: must be "usb" > > > + - usb-role-switch: use USB role switch to support dual-role switch > > > > I don't think we can add such a property. At least, we have to add "renesas," > > prefix. > > usb_role_switch_get api uses "usb-role-switch" property to get role switch linked with the device. > > HD3SS3220 port controller driver gets role switch handle linked with the device using usb_role_switch_get api. > That is the reason, I have added " usb-role-switch" property here. > > Do you have any other suggestion to get usb role switch handle? We can still change the API. Can we use the compatible for this? thanks, -- heikki
