Hi Rob and Yingjoe, On Thu, 2019-03-14 at 03:52 +0800, Rob Herring wrote: > On Wed, Mar 13, 2019 at 9:05 AM Stanley Chu <stanley.chu@xxxxxxxxxxxx> wrote: > > > > Hi Yingjoe, > > > > On Wed, 2019-03-13 at 18:21 +0800, Yingjoe Chen wrote: > > > On Wed, 2019-02-27 at 15:23 +0800, Stanley Chu wrote: > > > > Add UFS M-PHY node document for MediaTek SoC chips. > > > > > > > > Signed-off-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx> > > > > --- > > > > .../devicetree/bindings/phy/phy-mtk-ufs.txt | 35 +++++++++++++++++++ > > > > 1 file changed, 35 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt b/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt > > > > new file mode 100644 > > > > index 000000000000..5fc22c7fe0bc > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt > > > > @@ -0,0 +1,35 @@ > > > > +MediaTek Universal Flash Storage (UFS) M-PHY binding > > > > +-------------------------------------------------------- > > > > + > > > > +UFS M-PHY nodes are defined to describe on-chip UFS M-PHY hardware macro. > > > > +Each UFS M-PHY node should have its own node. > > > > + > > > > +To bind UFS M-PHY with UFS host controller, the controller node should > > > > +contain a phandle reference to UFS M-PHY node. > > > > + > > > > +Required properties for UFS M-PHY nodes: > > > > +- compatible : Compatible list, contains the following controller: > > > > + "mediatek,ufs-mphy" > > > > +- reg : Address and length of the UFS M-PHY register set. > > > > +- #phy-cells : This property shall be set to 0 > > > > +- clocks : List of phandle and clock specifier pairs. > > > > +- clock-names : List of clock input name strings sorted in the same > > > > + order as the clocks property. "unipro-clk" and > > > > + "mp-clk" are mandatory. > > > > > > All names in clock-names are clock, don't need to add -clk again. > > > Please describe shortly what these clock are used. Will add it. > > > > > > > Sorry this mail is marked as [SPAM] so I did not notice this before > > sending the same question to Rob. > > > > This style seems suitable in phy documents but existed ufs documents > > already have lots of "_clk" so I am confused. > > > > Maybe I need to drop "-clk" in phy documents and use "_clk" in ufs > > documents? > > > > Or wait for Rob's feedback in another mail? > > Generally, -clk or _clk is considered redundant, but maybe you need > this to be consistent with already defined names? > > Also, there's cases like pclk or aclk and dropping 'clk' on those > wouldn't make much sense. > Thanks so much for clear explanation. I will try to fix redundant clock names in next version. > Rob Thanks, Stanley > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-mediatek
