On 11/03/2019 20:01, Sean Wang wrote:
> Hi,
>
> On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang
> <hsin-hsiung.wang@xxxxxxxxxxxx> wrote:
>>
>> clean up code
>>
>> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@xxxxxxxxxxxx>
>> ---
>> drivers/mfd/mt6397-core.c | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
>> index 77b64bd..acb9812 100644
>> --- a/drivers/mfd/mt6397-core.c
>> +++ b/drivers/mfd/mt6397-core.c
>> @@ -18,17 +18,17 @@
>> #include <linux/of_irq.h>
>> #include <linux/regmap.h>
>> #include <linux/mfd/core.h>
>> -#include <linux/mfd/mt6397/core.h>
>> #include <linux/mfd/mt6323/core.h>
>> -#include <linux/mfd/mt6397/registers.h>
>> +#include <linux/mfd/mt6397/core.h>
>> #include <linux/mfd/mt6323/registers.h>
>> +#include <linux/mfd/mt6397/registers.h>
>>
>> #define MT6397_RTC_BASE 0xe000
>> #define MT6397_RTC_SIZE 0x3e
>>
>> -#define MT6323_CID_CODE 0x23
>> -#define MT6391_CID_CODE 0x91
>> -#define MT6397_CID_CODE 0x97
>> +#define MT6323_CHIP_ID 0x23
>> +#define MT6391_CHIP_ID 0x91
>> +#define MT6397_CHIP_ID 0x97
>>
>
> It would be not necessary to simply rename the definition or do you
> have a strong reason to do that?
>
I agree, apart, please provide a sound commit message.
"clean up code" is difficult to understand.
Regards,
Matthias
>> static const struct resource mt6397_rtc_resources[] = {
>> {
>> @@ -298,7 +298,7 @@ static int mt6397_probe(struct platform_device *pdev)
>> return pmic->irq;
>>
>> switch (id & 0xff) {
>> - case MT6323_CID_CODE:
>> + case MT6323_CHIP_ID:
>> pmic->int_con[0] = MT6323_INT_CON0;
>> pmic->int_con[1] = MT6323_INT_CON1;
>> pmic->int_status[0] = MT6323_INT_STATUS0;
>> @@ -312,8 +312,8 @@ static int mt6397_probe(struct platform_device *pdev)
>> 0, pmic->irq_domain);
>> break;
>>
>> - case MT6397_CID_CODE:
>> - case MT6391_CID_CODE:
>> + case MT6391_CHIP_ID:
>> + case MT6397_CHIP_ID:
>> pmic->int_con[0] = MT6397_INT_CON0;
>> pmic->int_con[1] = MT6397_INT_CON1;
>> pmic->int_status[0] = MT6397_INT_STATUS0;
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> Linux-mediatek mailing list
>> Linux-mediatek@xxxxxxxxxxxxxxxxxxx
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
