---------- Forwarded message --------- From: Hao Zhang <hao5781286@xxxxxxxxx> Date: 2019年3月12日周二 下午12:59 Subject: Re: [PATCH v3 1/6] Documentation: ARM: sunxi: pwm: add Allwinner sun8i. To: Thierry Reding <thierry.reding@xxxxxxxxx> Thierry Reding <thierry.reding@xxxxxxxxx> 于2018年12月21日周五 上午1:50写道： > > On Mon, Nov 26, 2018 at 12:18:59AM +0800, Hao Zhang wrote: > > This patch adds Allwinner sun8i pwm binding document. > > > > Signed-off-by: Hao Zhang <hao5781286@xxxxxxxxx> > > --- > > .../devicetree/bindings/pwm/pwm-sun8i.txt | 24 ++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sun8i.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt b/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt > > new file mode 100644 > > index 0000000..7531d85 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt > > @@ -0,0 +1,24 @@ > > +Allwinner sun8i R40/V40/T3 SoC PWM controller > > + > > +Required properties: > > + - compatible: Should be one of: > > + - "allwinner,sun8i-r40-pwm" > > + - reg: Physical base address and length of the controller's registers > > + - interrupts: Should contain interrupt. > > + - clocks: From common clock binding, handle to the parent clock. > > + - clock-names: Must contain the clock names described just above. > > + - pwm-channels: PWM channels of the controller. > > Why do you need this? In the cover letter you say: > > "The sun8i R40/T3/V40 PWM has 8 PWM channals ..." > > Why does this need to be specified in the DT? T3 PWM has 8 channals, i think it is necessary to tell user how to specify it Instead of hardcode the channal myself :) Thanks for review :) > > Thierry > -----BEGIN PGP SIGNATURE----- > > iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlwb1k4ACgkQ3SOs138+ > s6EOyA//auHjqjKwvjCLwWgHXdVr26cFUnFn/Ml6ZHHRe+oLCiYsatv4AZfGFvZ7 > CIGWN3zUu9c5YoDOd1isauQYgRtTsShWYC4gPxFFK9hWfb8f3o/wG60whkNDuvLL > 1SAQ/KJTC01LQIEXfHlb60EPvKCtt4YUQG4PkTGBGOHSO+MhWQHRLy5aLaq+d3yH > KHaDZ0PuZvYNnFWi7W/ggraiIlRToPH8HanFzGew+gUfPjClrczjrGqgn8u0bAL6 > MuKDMHLgjI/D8cs7XIaXc/OCPsp69B4JGrRJsxYh0KGKthaYDeKAUERpvsltDhGT > oTB55mJPZlriaiEOSwPrj+M0JQe9AnUIBVEiSIP2dSn8+rcSlWd10ysEjnCH/Ea7 > ARkamiRCk2hgOhZlDZcm+hjh7VxnJinaYahGFXMszpVgCScHT/fjZKexGqX8NJa8 > EWRJjeJaS1jLpLb7ZhM0iZrhzSC638G/5z3+1CWmyxwOvICb0FXzQDCTNSm1t8DO > NicV26tAWMIvDEW5PcTqrJaSvQmNrr4MiBiqocKs4N+ZA7Ey8JQW0oUFzwiwD6Ew > HaOuVXDlha1SZNK2tEnTDsTctXefl+eB7xeQ8MOHPp3yeKrpQlj4gHSyNOboEaXR > 8el/ZC1gGYHPeFGPSgXTbRNFwNY8/9GKPfP5cUgLc+e1B7oWAHg= > =9v1O > -----END PGP SIGNATURE-----
