Hi Niklas, Thank you for the patch. On Sat, Mar 09, 2019 at 12:47:21AM +0100, Niklas Söderlund wrote: > The resets property will become mandatory to operate the device, list it > as such. All device tree source files have always included the reset > property so making it mandatory will not introduce any regressions. > > While at it improve the description for the clocks property. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > index d63275e17afdd180..9a0d0531c67df48c 100644 > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > @@ -18,7 +18,8 @@ Mandatory properties > > - reg: the register base and size for the device registers > - interrupts: the interrupt for the device > - - clocks: reference to the parent clock > + - clocks: A phandle + clock specifier for the module clock > + - resets: A phandle + reset specifier for the module reset > > The device node shall contain two 'port' child nodes according to the > bindings defined in Documentation/devicetree/bindings/media/ -- Regards, Laurent Pinchart