On Thu, Mar 7, 2019 at 9:25 PM Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > > > @@ -1512,6 +1513,7 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) > > const struct acpi_device_id *adev_id = NULL; > > const struct pci_device_id *pcidev_id = NULL; > > const struct of_device_id *of_id = NULL; > > + struct device *dev = &pdev->dev; > > enum pxa_ssp_type type; > > > > adev = ACPI_COMPANION(&pdev->dev); > > @@ -1566,9 +1568,10 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) > > ssp->pdev = pdev; > > ssp->port_id = pxa2xx_spi_get_port_id(adev); > > > > - pdata->is_slave = of_property_read_bool(pdev->dev.of_node, "spi-slave"); > > + pdata->is_slave = device_property_read_bool(dev, "spi-slave"); > Isn't this an unrelated change to the introduction of dma-burst-sz ? Yes, Jarkko did same comment. It's fixed in v2 which was sent several days ago. > Other than this : > Reviewed-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> Thanks! Does it applies to v2? > > Cheers. > > -- > Robert -- With Best Regards, Andy Shevchenko
