Hi, Shawn, > On Wed, Feb 27, 2019 at 09:57:52AM +0800, Alison Wang wrote: > > This patch adds pmu dt nodes for LS1028A. > > > > Signed-off-by: Alison Wang <alison.wang@xxxxxxx> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 5 +++++ > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > index a8cf92a..36ef9c5 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > @@ -89,6 +89,11 @@ > > IRQ_TYPE_LEVEL_LOW)>; > > }; > > > > + pmu { > > + compatible = "arm,armv8-pmuv3"; > > Shouldn't we use "arm,cortex-a72-pmu" as compatible for better? > [Alison] Yes, it is better as compatible. I will change it in v2. Thanks. Best Regards, Alison Wang > Shawn > > > + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>; > > + }; > > + > > gic: interrupt-controller@6000000 { > > compatible= "arm,gic-v3"; > > #address-cells = <2>; > > -- > > 1.7.1 > >