Hi Rob, On Mon, 2019-03-04 at 11:42 -0600, Rob Herring wrote: > On Sun, Feb 24, 2019 at 7:36 PM Min Guo <min.guo@xxxxxxxxxxxx> wrote: > > > > Hi Rob, > > On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote: > > > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@xxxxxxxxxxxx wrote: > > > > From: Min Guo <min.guo@xxxxxxxxxxxx> > > > > > > > > This adds support for MediaTek musb controller in > > > > host, peripheral and otg mode. > > > > > > > > Signed-off-by: Min Guo <min.guo@xxxxxxxxxxxx> > > > > --- > > > > changes in v5: > > > > suggested by Rob: > > > > 1. Modify compatible as > > > > - compatible : should be one of: > > > > "mediatek,mt-2701" > > > > ... > > > > followed by "mediatek,mtk-musb" > > > > 2. Add usb connector child node > > > > > > > > changes in v4: > > > > suggested by Sergei: > > > > 1. String alignment > > > > > > > > changes in v3: > > > > 1. no changes > > > > > > > > changes in v2: > > > > suggested by Bin: > > > > 1. Modify DRC to DRD > > > > suggested by Rob: > > > > 2. Drop the "<soc-model>-musb" in compatible > > > > 3. Remove phy-names > > > > 4. Add space after comma in clock-names > > > > --- > > > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++ > > > > 1 file changed, 54 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > new file mode 100644 > > > > index 0000000..0632e6e > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > @@ -0,0 +1,54 @@ > > > > +MediaTek musb DRD/OTG controller > > > > +------------------------------------------- > > > > + > > > > +Required properties: > > > > + - compatible : should be one of: > > > > + "mediatek,mt-2701" > > > > > > That looks like a top-level SoC compatible and doesn't match the > > > example. > > "mediatek,mt-2701" is an example, just to describe a specific SOC. > > May I modify compatibel like: > > compatible : should be "mediatek,mtk-musb" > > No, you should fix the example adding "mediatek,mtk-musb". OK. > Rob Regards, Min.
