On Mon, Mar 04, 2019 at 05:29:22PM +0000, Suzuki K Poulose wrote: [...] > > > To support for a funnel without any register address range (we have > > > support replicator like this mode), we also need to extend the driver > > > drivers/hwtracing/coresight/coresight-funnel.c. > > > > > > Mathieu, Mike, Suzuki, could you help confirm this is the right > > > direction we should move forward to? > > > > Leo, thanks for testing this out. Shiwanglai, please add Suzuki and > > myself to future revision of this set - this will help you getting a > > timely response for your work. Yeah, I didn't give a good example for this; just remind to Wanglai, usually we can add maintainers' email address in the "To:" list so this will be more friendly for email filters. > > As Leo pointed out we already have support for replicators that don't > > have a register map and the same thing should be done in this case. > > But contrary to what was done for replicators, I think we should keep > > the drivers in the same file as Russell did here[1]. That way we can > > keep all things funnel at the same place and reduce the amount of > > kernel configuration options. > > I back that. I have already merged the static and programmable replicators > into one and this should be out here soon. So, I back the single driver > approach for funnels. That's great! Thanks for advices, Mathieu & Suzuki. Will sync with you offline for proceeding. Thanks, Leo Yan
