> Subject: Re: [PATCH 1/3] arm64: dts: imx: Add i.mx8mm dtsi support
>
> Hi Ping,
>
> Thanks a lot for the patch. Few comments inline:
>
OK, I will fix these V2.
BR
Jacky Bai
> On Mon, 2019-03-04 at 09:12 +0000, Jacky Bai wrote:
> > +
> > + soc@0 {
> > + compatible = "simple-bus";
> > + #address-cells = <2>;
> > + #size-cells = <2>;
>
> This should be #address-cells = <1>; Look at the patches for 8MQ.
>
> >
> > + sdma2: dma-controller@302c0000 {
> > + compatible = "fsl,imx8mq-sdma",
> > "fsl,imx7d-sdma";
> > + reg = <0x0 0x302c0000 0x0 0x10000>;
> > + interrupts = <GIC_SPI 103
> > IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MM_CLK_SDMA2_ROOT>,
> > + <&clk IMX8MM_CLK_SDMA2_ROOT>;
> > + clock-names = "ipg", "ahb";
> > + #dma-cells = <3>;
> > + fsl,sdma-ram-script-name =
> > "imx/sdma/sdma-imx7d.bin";
> > + fsl,ratio-1-1;
>
> This property is not in the upstream kernel. Please remove it.
>
> > + status = "okay";
>
> No need to add status okay here. It is the default option.
>
> > + };
> > +
> > + sdma3: dma-controller@302b0000 {
> > + compatible = "fsl,imx8mq-sdma",
> > "fsl,imx7d-sdma";
> > + reg = <0x0 0x302b0000 0x0 0x10000>;
> > + interrupts = <GIC_SPI 34
> > IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MM_CLK_SDMA3_ROOT>,
> > + <&clk IMX8MM_CLK_SDMA3_ROOT>;
> > + clock-names = "ipg", "ahb";
> > + #dma-cells = <3>;
> > + fsl,sdma-ram-script-name =
> > "imx/sdma/sdma-imx7d.bin";
> > + fsl,ratio-1-1;
> > + status = "okay";
>
> Ditto.
>
> thanks,
> Daniel.
