On Mon, Mar 04, 2019 at 06:46:32AM +0000, Andy Tang wrote:
>
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@xxxxxxxxxx>
> > Sent: 2019年3月4日 14:21
> > To: Andy Tang <andy.tang@xxxxxxx>
> > Cc: Leo Li <leoyang.li@xxxxxxx>; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx;
> > daniel.lezcano@xxxxxxxxxx; rui.zhang@xxxxxxxxx; edubezval@xxxxxxxxx
> > Subject: Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node
> >
> > On Mon, Mar 04, 2019 at 11:21:11AM +0800, Yuantian Tang wrote:
> > > Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core
> > > cluster sensor is used to monitor the temperature of core and SoC
> > > platform is for platform. The current dts only support the first sensor.
> > > This patch adds the second sensor node to dts to enable it.
> > >
> > > Signed-off-by: Yuantian Tang <andy.tang@xxxxxxx>
> > > ---
> > > v2:
> > > - Add more information about sensors to description
> > > PS: In order to keep consistency to the first thermal-zone node, there
> > > will be "WARNING: line over 80 characters" warnings.
> > >
> > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 43
> > +++++++++++++++++++++--
> > > 1 files changed, 39 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > index 661137f..9f52bc9 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > @@ -129,19 +129,19 @@
> > > };
> > >
> > > thermal-zones {
> > > - cpu_thermal: cpu-thermal {
> > > + ccu {
> >
> > Is this change really necessary? What does 'ccu' stand for?
> I think so. ccu stands for core cluster unit. cpu is too general.
> On some platforms, there are more than one core clusters.
> At least we should change it to "core cluster" if short form is not appropriate.
Yes, please give it a more descriptive name.
Shawn
