Hi Andy, On 2019/3/2 23:56, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:06 AM Yu Chen <chenyu56@xxxxxxxxxx> wrote: >> >> This driver handles usb phy power on and shutdown for hi3660 Soc of >> Hisilicon. > > Few comments below. After fixing them, FWIW > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > >> +#define HI3660_USB_DEFAULT_PHY_PARAM 0x1c466e3 > > A bit of description would be nice to have what this value means. > OK. >> + /* delay for exit from IDDQ mode */ >> + usleep_range(100, 100); > > 100,100 ? I think you need to give a room to scheduler, at least 20% > margin would be good to have. > >> + /* delay for vbus valid */ >> + usleep_range(100, 100); > > Ditto. > > OK. Thanks Yu Chen
