On Thu, 28 Feb 2019 15:18:10 -0500 Robert Yang <decatf@xxxxxxxxx> wrote: > Document device tree bindings for Kionix KXCJK-1013 Accelerometer driver. > > Signed-off-by: Robert Yang <decatf@xxxxxxxxx> Hi Robert, Thanks for this. One comment inline. Jonathan > --- > .../bindings/iio/accel/kionix,kxcjk1013.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt > > diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt b/Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt > new file mode 100644 > index 000000000000..521c53799bc5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt > @@ -0,0 +1,18 @@ > +Kionix KXCJK-1013 Accelerometer device tree bindings > + > +Required properties: > + > +- compatible: Must be one of: > + "kionix,kxcjk1013" > + "kionix,kxcj91008" > + "kionix,kxtj21009" > + "kionix,kxtf9" > + "kionix,SMO8500" This looks like an ACPI binding rather than a device name. So I'd drop this last one. > + - reg: i2c slave address > + > +Example: > + > +kxtf9@f { > + compatible = "kionix,kxtf9"; > + reg = <0x0F>; > +};