Hi Neil, On Fri, Mar 1, 2019 at 5:43 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > > Hi Martin, > > On 01/03/2019 16:26, Martin Blumenstingl wrote: > > Hi Neil, > > > > On Fri, Mar 1, 2019 at 11:22 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > >> > >> Add Amlogic G12A Family CPU clocks bindings, only export CPU_CLK since > >> it should be the only ID used. > > is this also true for the CPU post-dividers (APB, ATB, AXI, CPU CLK TRACE)? > > Do we need these to be exported ? I'm not sure as I couldn't find more details about APB, ATB and AXI on G12A: - APB and ATB may be needed by the CoreSight bindings (Documentation/devicetree/bindings/arm/coresight.txt) - AXI may be needed by the VPU driver (the S912 datasheet mentions in OSD1_AFBCD_ENABLE: "id_fifo_thrd : unsigned , default = 64, axi id fifo threshold") if you don't know either then I'm fine with skipping them for now, we can still export them later. Martin
