On 2/28/19 12:55 AM, Rob Herring wrote: > On Wed, 27 Feb 2019 10:34:46 +0100, Amelie Delaunay wrote: >> This patch adds documentation of device tree bindings for the >> STMicroelectronics Multi-Function eXpander (STMFX) MFD core. >> >> Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx> >> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/mfd/stmfx.txt | 28 +++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/stmfx.txt >> > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > I'm sorry Rob, I forgot to add your Reviewed-by on this patch, which is identical to v3. I reposted the whole series, due to changes in MFD driver with side effect in pinctrl driver, but bindings (MFD and pinctrl) didn't change between the two versions. I stated the changes in cover letter. Should I have removed the bindings patches from the series ?