Hi, On Mon, Feb 25, 2019 at 1:05 PM David Summers <beagleboard@xxxxxxxxxxxxxxxxxxx> wrote: > I was going to say that: > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/mmc/mmc.txt > says: > > - disable-wp: When set no physical WP line is present. This property should > only be specified when the controller has a dedicated write-protect > detection logic. > > Do we know that dw_mmc-rockchip.c has write-protect detection logic? Its > not mentioned in the code, but I don't know my way round the mmc code. In general dw_mmc has dedicated write protect logic. ...so yes the property is needed. -Doug
