Hi Stephen, Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote on Fri, 23 Nov 2018 10:44:39 +0100: > Hello, > > As part of an effort to bring suspend to RAM support to the Armada > 3700 SoC (main target: ESPRESSObin board), there are small things to > do in the Armada 3700 peripherals clock driver: > > * On this SoC, the PCIe controller gets fed by a gated clock in the > south bridge. This clock is missing in the current driver, patch 1 > adds it. > > * Because of a constraint in the PCI core, the resume function of a > PCIe controller driver must be run at an early stage > (->suspend/resume_noirq()), before the core tries to ->read/write() > in the PCIe registers to do more configuration. Hence, the PCIe > clock must be resumed before. This is enforced thanks to two > changes: > 1/ Add device links to the clock framework. This enforce order in > the PM core: the clocks are resumed before the consumers. Series > has been posted, see [1]. > 2/ Even with the above feature, the clock's resume() callback is > called after the PCI controller's resume_noirq() callback. The > only way to fix this is to change the "priority" of the clock > suspend/resume callbacks. This is done in patch 2. > > * The bindings are updated with the PCI clock in patch 4 while patch 3 > is just a typo correction in the same file. > > If there is anything unclear please feel free to ask. > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/614527.html This series does not depend on the clock device links work so I wonder if you are still considering it? Thanks, Miquèl
