On 18/02/2019 16.35, Tony Lindgren wrote: > * Lokesh Vutla <lokeshvutla@xxxxxx> [190216 03:30]: >> On 2/12/2019 1:12 PM, Lokesh Vutla wrote: >>> +TISCI Interrupt Router Node: >>> +---------------------------- >>> +- compatible: Must be "ti,sci-intr". >>> +- interrupt-controller: Identifies the node as an interrupt controller >>> +- #interrupt-cells: Specifies the number of cells needed to encode an >>> + interrupt source. The value should be 4. >>> + First cell should contain the TISCI device ID of source >>> + Second cell should contain the interrupt source offset >>> + within the device >>> + Third cell specifies the trigger type as defined >>> + in interrupts.txt in this directory. >>> + Fourth cell should be 1 if the irq is coming from >>> + interrupt aggregator else 0. >>> +- ti,sci: Phandle to TI-SCI compatible System controller node. >>> +- ti,sci-dst-id: TISCI device ID of the destination IRQ controller. >> >> Please help me here. As said this is the TISCI device id for the host >> interrupt controller. While sending message to the system co-processor >> this ID needs to be specified so that the irq route gets discovered and >> configured. Atleast with the current design device Ids are not >> discoverable. Can you mention what can be improved here? Is there any >> such example where a firmware supports querying the deivce ids? >> >> Also do you have any further comments on this patch? > > No reg property above. So if the interrupt router is not accessible > by Linux like you're saying, you should not set up a dts node for > it at all. It is accessible via tisci but no direct register access. > > Regards, > > Tony > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
