> From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: Thursday, February 14, 2019 6:27 AM> > On Mon, Feb 11, 2019 at 03:35:40PM +0000, Marc Zyngier wrote: > > On 31/01/2019 08:03, Aisheng Dong wrote: > > > Not all 64 interrupts may be used in one group. e.g. most irqsteer > > > in imx8qxp and imx8qm subsystems supports only 32 interrupts. > > > > > > As the IP integration parameters are Channel number and interrupts > > > number, let's use fsl,irqs-num to represents how many interrupts > > > supported by this irqsteer channel. > > > > > > Cc: Marc Zyngier <marc.zyngier@xxxxxxx> > > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > > > Cc: devicetree@xxxxxxxxxxxxxxx > > > Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx> > > > --- > > > ChangeLog: > > > v1->v2: > > > * change property name fsl,irqs-per-chan to fsl,num-irqs. > > > --- > > > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 6 > +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqstee > > > r.txt > > > b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqstee > > > r.txt > > > index 45790ce..6d0a41b 100644 > > > --- > > > a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqstee > > > r.txt > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irq > > > +++ steer.txt > > > @@ -16,8 +16,8 @@ Required properties: > > > - #interrupt-cells: Specifies the number of cells needed to encode an > > > interrupt source. The value must be 1. > > > - fsl,channel: The output channel that all input IRQs should be steered > into. > > > -- fsl,irq-groups: Number of IRQ groups managed by this controller > instance. > > > - Each group manages 64 input interrupts. > > > +- fsl,num-irqs: Number of input interrupts of this channel. > > > + Should be multiple of 32 input interrupts and up to 512 interrupts. > > > > > > Example: > > > > > > @@ -28,7 +28,7 @@ Example: > > > clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > > > clock-names = "ipg"; > > > fsl,channel = <0>; > > > - fsl,irq-groups = <1>; > > > + fsl,num-irqs = <64>; > > > interrupt-controller; > > > #interrupt-cells = <1>; > > > }; > > > > > > > This is a change to an existing binding, so I'd need the Ack from a DT > > maintainer before I can queue this. > > The DT maintainer doesn't care as long as there's an explanation that says it's > breaking compatibility and why it is okay to do so. This one doesn't do that. > Got it. I will add them and resend, thanks for the suggestion. Regards Dong Aisheng > Rob
