On Mon, Feb 18, 2019 at 9:03 PM Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> wrote:
>
> Hi,
> On Tue, 2019-02-19 at 09:50 +0800, Chen Yu wrote:
> > Hi,
> >
> > On 2019/2/19 4:18, Rob Herring wrote:
> > > On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote:
> > >> This patch adds binding documentation for supporting the hi3660 usb
> > >> phy on boards like the HiKey960.
> > >>
> > >> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > >> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > >> Cc: John Stultz <john.stultz@xxxxxxxxxx>
> > >> Cc: Binghui Wang <wangbinghui@xxxxxxxxxxxxx>
> > >> Signed-off-by: Yu Chen <chenyu56@xxxxxxxxxx>
> > >> ---
> > >> v1:
> > >> * Fix some format error as suggested by Rob.
> > >> v2:
> > >> * Change hi3660 usb PHY to hi3660 USB PHY
> > >> ---
> > >> ---
> > >> .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 21 +++++++++++++++++++++
> > >> 1 file changed, 21 insertions(+)
> > >> create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> > >> new file mode 100644
> > >> index 000000000000..f9a3d56cfdd2
> > >> --- /dev/null
> > >> +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> > >> @@ -0,0 +1,21 @@
> > >> +Hisilicon hi3660 USB PHY
> > >> +-----------------------
> > >> +
> > >> +Required properties:
> > >> +- compatible: should be "hisilicon,hi3660-usb-phy"
> > >> +- #phy-cells: must be 0
> > >> +- hisilicon,pericrg-syscon: phandle of syscon used to control phy.
> > >> +- hisilicon,pctrl-syscon: phandle of syscon used to control phy.
> > >> +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy.
> > >> +- hisilicon,eye-diagram-param: parameter set for phy
> > >> +Refer to phy/phy-bindings.txt for the generic PHY binding properties
> > >> +
> > >> +Example:
> > >> + usb-phy {
> > >> + compatible = "hisilicon,hi3660-usb-phy";
> > >> + #phy-cells = <0>;
> > >> + hisilicon,pericrg-syscon = <&crg_ctrl>;
> > >> + hisilicon,pctrl-syscon = <&pctrl>;
> > >> + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>;
> > >
> > > Are most of the registers within one of these blocks? If so, make this
> > > node a child of that node.
> > I met a problem when I made this node a child of the syscon node,
> > the driver "phy-hi3660-usb3" was not probed.
> > Do you have any idea about how to make it probed when it is a child node?
> call of_platform_populate() in parent node's driver,
> but I don't know whether it's a standard way
It is. The other way is adding 'simple-mfd' compatible if there is no
driver for the parent.
Rob
