Hi Mark > On Mon, Mar 17, 2014 at 07:29:55PM -0700, Kuninori Morimoto wrote: > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > Support for loading the Renesas R-Car sound driver via DeviceTree. > > So, I've applied this but it needs some improvement - please do that > incrementally. One thing you should have done here is CC the binding to > the DT list and maintainers for review. > > > +- rcar_sound,ssi : SSI subnode > > +- rcar_sound,scu : SCU subnode > > +- rcar_sound,dai : DAI subnode > > This needs clearer documentation saying what the subnodes are - they're > actually collections of further nodes, each of which represents > something in the hardware. The examples are fairly clear but the text > needs more than just "subnode". Someone should be able to tell how to > write the DT just given the datasheet and this document. I see. will do Thank you for your advice Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
