Hi David, we need a better patch subject here e.g. ARM: dts: rk3288-tinker: Fix SD card detection plus a Fixes tag for the commit we want to fix. > David Summers <beagleboard@xxxxxxxxxxxxxxxxxxx> hat am 17. Februar 2019 um 13:15 geschrieben: > > > This patch makes some minor changes to how the sd card is > described in the device tree for the ASUS Tinker Board (S). In > particular on the Tinker Board S, when booted from the eMMC, and with > no card in the sd slot, and the log has endless messages about not > being able to detect the card. > > Several methods to remove this error have been tried, the only one > that works is the broken-cd and so that is what is applied here. > > Alas the ASUS schematic is not clear enough to indicate if the card > detect is wired up to the cpu, the schematic does not show internal > wiring on the Tinker Board! > > Now this error didn't show up on the Tinker Board, as that machine > only boots where there is a sd card installed. However as the TB and > TBS are so similar it is expected that the Tinker Board also doesn't > have a functioning card detect. Hence the change here is made to the > dtsi file, so it applies to both TB and TBS. > > The disable-wp is also removed, it doesnt seem needed on the micro > sdcard slots, and without thisn the card can still be written > to. Hence this flag is also removed. > > Signed-off-by: David Summers <beagleboard@xxxxxxxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/rk3288-tinker.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi > index 2b38075a2917..fceaeed44e34 100644 > --- a/arch/arm/boot/dts/rk3288-tinker.dtsi > +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi > @@ -432,9 +432,7 @@ > bus-width = <4>; > cap-mmc-highspeed; > cap-sd-highspeed; > - card-detect-delay = <200>; > - disable-wp; /* wp not hooked up */ I think we should keep as long as it doesn't hurt. > + broken-cd; > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>; > status = "okay"; > -- > beagleboard@xxxxxxxxxxxxxxxxxxx > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
