On Sun, Feb 17, 2019 at 11:31:23AM -0300, Fabio Estevam wrote:
> Add support for the VXT VL050-8048NT-C01 800x480 panel to the
> panel-simple driver.
>
> This panel is used on some boards manufactured by TechNexion, such as
> imx7d-pico.
>
> Reviewed-by: Otavio Salvador <otavio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 5fbee83..2e76e95 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2410,6 +2410,30 @@ static const struct panel_desc urt_umsh_8596md_parallel = {
> .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> };
>
> +static const struct drm_display_mode vl050_8048nt_c01_mode = {
> + .clock = 33333,
> + .hdisplay = 800,
> + .hsync_start = 800 + 210,
> + .hsync_end = 800 + 210 + 20,
> + .htotal = 800 + 210 + 20 + 46,
> + .vdisplay = 480,
> + .vsync_start = 480 + 22,
> + .vsync_end = 480 + 22 + 10,
> + .vtotal = 480 + 22 + 10 + 23,
> + .vrefresh = 60,
> +};
No need for .flags?
Example: .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +
> +static const struct panel_desc vl050_8048nt_c01 = {
> + .modes = &vl050_8048nt_c01_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 120,
> + .height = 76,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
What about .bus_flags?
Example: .bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE,
The examples are random from the panel-simple driver.
I could not find any datasheet at http://www.vxt.com.tw
for the panel.
With my comments considered you can add:
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
