>-----Original Message----- >From: Andrew Lunn <andrew@xxxxxxx> >Sent: Friday, February 15, 2019 3:35 PM >To: Claudiu Manoil <claudiu.manoil@xxxxxxx> >Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; David S . >Miller <davem@xxxxxxxxxxxxx>; Alexandru Marginean ><alexandru.marginean@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; >devicetree@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx >Subject: Re: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO >support > >On Fri, Feb 15, 2019 at 12:10:14PM +0200, Claudiu Manoil wrote: >> Each ENETC PF has its own MDIO interface, the corresponding >> MDIO registers are mapped in the ENETC's Port register block. >> The current patch adds a driver for these PF level MDIO buses, >> so that each PF can manage directly its own external link. >> >> Signed-off-by: Alex Marginean <alexandru.marginean@xxxxxxx> >> Signed-off-by: Claudiu Manoil <claudiu.manoil@xxxxxxx> >> --- >> v2 - used readx_poll_timeout() >> - added mdio node child to the port node > >Hi Claudiu > >Please document this in the device tree binding. > Hi, I don't really see what bindings would need to be documented, as the node names and properties used so far are common. Like, the "mdio" node name is common, the enetc ports are "pci" nodes, nothing special for these. What's missing? Regards, Claudiu
