Vince Bridgers <vbridgers2013@xxxxxxxxx> : > See comments inline > > On Sat, Mar 22, 2014 at 1:23 AM, Byungho An <bh74.an@xxxxxxxxxxx> wrote: > > From: Siva Reddy <siva.kallam@xxxxxxxxxxx> > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > > [snip] > > + /* program desc registers */ > > + writel(dma_tx >> 32, > > + ioaddr + SXGBE_DMA_CHA_TXDESC_HADD_REG(cha_num)); > > + writel(dma_tx & 0xFFFFFFFF, > > + ioaddr + SXGBE_DMA_CHA_TXDESC_LADD_REG(cha_num)); > > + > > + writel(dma_rx >> 32, > > + ioaddr + SXGBE_DMA_CHA_RXDESC_HADD_REG(cha_num)); > > + writel(dma_rx & 0xFFFFFFFF, > > + ioaddr + SXGBE_DMA_CHA_RXDESC_LADD_REG(cha_num)); > > use upper_32_bits and lower_32_bits for extracting the upper/lower > 32-bit portions of a phys addrs. See > https://www.kernel.org/doc/htmldocs/device-drivers/API-upper-32-bits.html. OK. [snip] > > + /* save the skb address */ > > + tqueue->tx_skbuff[entry] = skb; > > + > > + if (!is_jumbo) { > > + tx_desc->tdes01 = dma_map_single(priv->device, skb->data, > > + no_pagedlen, DMA_TO_DEVICE); > > + if (dma_mapping_error(priv->device, tx_desc->tdes01)) > > + pr_err("%s: TX dma mapping failed!!\n", __func__); > > + > > + priv->hw->desc->prepare_tx_desc(tx_desc, 1, no_pagedlen, > > + no_pagedlen); > > you're prototype is void (*prepare_tx_desc)(struct sxgbe_tx_norm_desc > *p, u8 is_fd, int buf1_len, int pkt_len, int cksum) defined in > sxgbe_desc.h, but you're usage is different? Am I missing something > here? I found this when I tried to download this first patch and > compile it independent of the application of the entire series. OK, I'll fix it actually csum will be used after this patch.... > > > + } > > + > > + for (frag_num = 0; frag_num < nr_frags; frag_num++) { > > + const skb_frag_t *frag = &skb_shinfo(skb)->frags[frag_num]; > > + int len = skb_frag_size(frag); > > + > > + entry = (++tqueue->cur_tx) % tx_rsize; > > + tx_desc = tqueue->dma_tx + entry; > > + tx_desc->tdes01 = skb_frag_dma_map(priv->device, frag, 0, len, > > + DMA_TO_DEVICE); > > + > > + tqueue->tx_skbuff_dma[entry] = tx_desc->tdes01; > > + tqueue->tx_skbuff[entry] = NULL; > > + > > + /* prepare the descriptor */ > > + priv->hw->desc->prepare_tx_desc(tx_desc, 0, len, > > + len); > > you're prototype is void (*prepare_tx_desc)(struct sxgbe_tx_norm_desc > *p, u8 is_fd, int buf1_len, int pkt_len, int cksum) defined in > sxgbe_desc.h, but you're usage is different? Am I missing something > here? I found this when I tried to download this first patch and > compile it independent of the application of the entire series. same above [snip] > > +#endif /* __SXGBE_PLATFORM_H__ */ > > -- > > 1.7.10.4 > > Have you tried applying this series to this point and compiling? Since > the prepare_tx_desc usage and prototype are different, I'm not so sure > the series applied up to this patch will successfully compile. sure with this series.. please refer above. > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe netdev" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
