On 2/14/2019 6:02 AM, Rob Herring wrote: > On Wed, Feb 13, 2019 at 4:09 PM Ray Jui <ray.jui@xxxxxxxxxxxx> wrote: >> >> >> >> On 2/13/2019 1:18 PM, Rob Herring wrote: >>> On Mon, Feb 04, 2019 at 03:15:52PM -0800, Ray Jui wrote: >>>> From: Rayagonda Kokatanur <rayagonda.kokatanur@xxxxxxxxxxxx> >>>> >>>> Update iProc I2C binding document to add new compatible string >>>> "brcm,iproc-nic-i2c". Optional property "brcm,ape-hsls-addr-mask" is >>>> also added that allows configuration of the host view into the APE's >>>> address for "brcm,iproc-nic-i2c" >>>> >>>> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@xxxxxxxxxxxx> >>>> Signed-off-by: Ray Jui <ray.jui@xxxxxxxxxxxx> >>>> --- >>>> Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt >>>> index d3a3620b1f06..02e82d20239e 100644 >>>> --- a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt >>>> +++ b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt >>>> @@ -3,7 +3,7 @@ Broadcom iProc I2C controller >>>> Required properties: >>>> >>>> - compatible: >>>> - Must be "brcm,iproc-i2c" >>>> + Must be "brcm,iproc-i2c" or "brcm,iproc-nic-i2c" >>>> >>>> - reg: >>>> Define the base and range of the I/O address space that contain the iProc >>>> @@ -24,6 +24,9 @@ Optional properties: >>>> Should contain the I2C interrupt. If unspecified, driver will fall back to >>>> polling mode >>>> >>>> +- brcm,ape-hsls-addr-mask: >>>> + Required for "brcm,iproc-nic-i2c". Host view of address mask into the >>>> + 'APE' co-processor >>> >>> What's the data type and size? What are valid values? >> >> It's an unsigned u32 mask value. An example of a valid value is for >> example 0x03400000. Do you want any of these added to the paragraph above? > > Yes. Bindings should define constraints. Okay will do! Thanks. > > Rob >
