On Tue, Mar 18, 2014 at 10:04:50AM +0100, Maxime Ripard wrote: > On Sat, Mar 15, 2014 at 04:43:43PM +0100, Carlo Caione wrote: > > This dtsi describes the axp209 PMIC, and is to be included from inside > > the i2c controller node to which the axp209 is connected. > > > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > Signed-off-by: Carlo Caione <carlo@xxxxxxxxxx> > > --- > > arch/arm/boot/dts/x-powers-axp209.dtsi | 60 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 arch/arm/boot/dts/x-powers-axp209.dtsi > > > > diff --git a/arch/arm/boot/dts/x-powers-axp209.dtsi b/arch/arm/boot/dts/x-powers-axp209.dtsi > > new file mode 100644 > > index 0000000..d272e67 > > --- /dev/null > > +++ b/arch/arm/boot/dts/x-powers-axp209.dtsi > > @@ -0,0 +1,60 @@ > > +/* > > + * x-powers,axp209 common code to be include from inside the axp209 node > > + * > > + * Copyright 2014 - Carlo Caione <carlo@xxxxxxxxxx> > > + * > > + * The code contained herein is licensed under the GNU General Public > > + * License. You may obtain a copy of the GNU General Public License > > + * Version 2 or later at the following locations: > > + * > > + * http://www.opensource.org/licenses/gpl-license.html > > + * http://www.gnu.org/copyleft/gpl.html > > + */ > > + > > I didn't even know such a thing was possible :) > Nice hack. Kudos to Hans ;) > > > + compatible = "x-powers,axp209"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > However, I'd move this out of it, and in the board file, so that we > actually get an idea by looking at the board DTS of what device we are > actually registering at this given address, and what it's capable of. Do you mean the whole dtsi or just those three lines? -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html