On 21/03/2014 at 22:31:09 +0100, Sebastian Hesselbarth wrote :
> On 03/21/2014 09:08 PM, Alexandre Belloni wrote:
> >Document the device tree bindings for the PLLs found on the Marvell Berlin SoCs.
> >
> >Cc: devicetree@xxxxxxxxxxxxxxx
>
> You forgot to add Mark Rutland's Reviewed-by. He didn't mentioned it
> explicitly but his "Otherwise this looks fine to me" on v1, is as good
> as a Reviewed-by. But, no need to resend, I'll fix it up.
>
Ok, I would have preferred an explicit one ;)
> Also, everything above the '---' will be part of your commit log. While
> the Signed-off-by and Reviewed-by should be in there, Cc's really don't
> need to.
>
Ok, it seemed common practice to put it in the commit log:
$ git log | grep " Cc:" | wc -l
157126
But I'll do as you suggest from now. Actually, I didn't know you could
do like that.
> You can add another '---' to separate commit message and some stuff
> you want to have early in you email with:
>
> Blablabla commit message.
>
> Signed-off-by: ...
> Reviewed-by: ...
> ---
> Changelog:
> - blabla
>
> Cc: cc-me-recipient
> ...
> ---
> .../devicetree/bindings/clock/berlin-clock.txt | 29
> ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/clock/berlin-clock.txt
>
> diff --git
> a/Documentation/devicetree/bindings/clock/berlin-clock.txt
> b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> ...
>
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> >---
> > .../devicetree/bindings/clock/berlin-clock.txt | 29 ++++++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/berlin-clock.txt
> >
> >diff --git a/Documentation/devicetree/bindings/clock/berlin-clock.txt b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> >new file mode 100644
> >index 000000000000..49b7860bffb8
> >--- /dev/null
> >+++ b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> >@@ -0,0 +1,29 @@
> >+Device Tree Clock bindings for Marvell Berlin clocks
> >+
> >+This binding uses the common clock binding[1].
> >+
> >+[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
> >+
> >+Required properties:
> >+- compatible: shall be one of the following:
> >+ "marvell,berlin2-pll",
> >+ "marvell,berlin2q-pll":
> >+ CPU PLL and System PLL
> >+- reg: Address and length of the clock register set.
> >+- #clock-cells: from common clock binding; shall be set to 0.
> >+- clocks: from common clock binding
> >+
> >+smclk: sysmgr-clock {
> >+ compatible = "fixed-clock";
> >+ #clock-cells = <0>;
> >+ clock-frequency = <25000000>;
> >+};
> >+
> >+cpupll: cpupll@ea003c {
> >+ compatible = "marvell,berlin2-pll";
> >+ clocks = <&smclk>;
> >+ #clock-cells = <0>;
> >+ reg = <0xea003c 0x8>;
> >+};
> >+
> >+
> >
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
