On 2019-02-13 04:54, Kees Cook wrote: > On Wed, Jan 23, 2019 at 4:06 AM liaoweixiong > <liaoweixiong@xxxxxxxxxxxxxxxxx> wrote: >> >> Why should we need pstore_block? >> 1. Most embedded intelligent equipment have no persistent ram, which >> increases costs. We perfer to cheaper solutions, like block devices. >> In fast, there is already a sample for block device logger in driver >> MTD (drivers/mtd/mtdoops.c). >> 2. Do not any equipment have battery, which means that it lost all data >> on general ram if power failure. Pstore has little to do for these >> equipments. >> >> [PATCH v7] >> On patch 1: >> 1. Fix line over 80 characters. >> On patch 2: >> 1. Insert a separate patch for DT bindings. > > This is looking good. Can you address the DT bindings review concerns, > and send a v8? > Sure. I had little time to send patches as i caught up with the Spring Festival some days ago, the most grand festival of China. I'll do it before this weekend, which is already in my plan. > Thanks! > -- liaoweixiong