On 12/02/2019 02:34:05+0000, Trent Piepho wrote: > Since this documents multiple chips controlled by the isl1208 driver, > name it isil,isl1208.txt, as the convention is to use the base driver > name in the bindings document for drivers with multiple devices. > > Include all chips supported by this driver in the docs. Make it > clear which properties apply to which chips. > > Expand documentation for existing isil,evienb property to explain > operation in more detail. Existing docs just describe it in terms of > setting a bit in a register. > > CC: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> > CC: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > CC: Rob Herring <robh+dt@xxxxxxxxxx> > CC: Mark Rutland <mark.rutland@xxxxxxx> > CC: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Trent Piepho <tpiepho@xxxxxxxxxx> > --- > .../devicetree/bindings/rtc/isil,isl1208.txt | 38 ++++++++++++++++++++++ > .../devicetree/bindings/rtc/isil,isl1219.txt | 29 ----------------- > 2 files changed, 38 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.txt > delete mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1219.txt > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com