Re: [PATCH V2 2/4] arm64: dts: imx8qxp: added ddr performance monitor nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 12, 2019 at 3:04 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> On Tue, Feb 12, 2019 at 6:59 PM Frank Li <frank.li@xxxxxxx> wrote:
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 4c3dd95..243d7b3 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -79,6 +79,13 @@
> >                 interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> >         };
> >
> > +       ddr_pmu0: ddr_pmu@5c020000 {
>
> It seems you ignored the commend I made in the previous version.
>
> Here it goes again:
>
> Underscores should not be used in node names. You could use
> pmu@5c020000 instead.

Sorry, I missed this.
how about ddr-pmu0

pmu is already used by arm pmu

best regards
Frank Li



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux