On 03/21/2014 06:24 PM, Gerhard Sittig wrote: > On Thu, Mar 20, 2014 at 20:55 +0100, Sebastian Andrzej Siewior wrote: >> >> The cycloneV has three gpio controllers, each one with 29 gpios. This patch >> adds the three controller with the gpio driver which is now sitting the >> gpio tree. > > The third bank should have 27 pins, only the first two have 29. It is not a bank it is a complete controller. Why 27 pins? The reference manual says that there register 0…28. > The commit message probably should not discuss which git tree a > driver currently resides in. This is just a temporary detail > which no longer applies to the mainline source base where your > patch will end up in. This patch adds a binding which is not in kernel. It is worth to mention. > > > virtually yours > Gerhard Sittig > Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
