Hi Virendra, On Mon, Feb 11, 2019 at 5:02 PM Virendra Kakade <virendra.kakade@xxxxxx> wrote: > > Document bindings for E31x device PMU MFD driver. > > Signed-off-by: Virendra Kakade <virendra.kakade@xxxxxx> > --- > Documentation/devicetree/bindings/mfd/e31x-pmu.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/e31x-pmu.txt > > diff --git a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt > new file mode 100644 > index 000000000000..ebb5625f6c74 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt > @@ -0,0 +1,14 @@ > +Ettus Research/National Instruments E31x PMU MFD driver > + > +Required properties: > +- compatible : Must be "ni,e31x-pmu" > +- regmap : Must be <®mapnode> > + > +Example: > + > +pmu { > + compatible = "ni,e31x-pmu"; > + regmap = <&devctrl>; > + status = "okay"; Please drop this. > > +}; > + > -- > 2.17.1 > Your binding patches should have "dt-bindings: ... " in the commit message. Please fix that when you resubmit your series. Cheers, Moritz