Hi Andrew-sh.Cheng,
On 19. 1. 29. 오후 3:35, Andrew-sh Cheng wrote:
> From: "Andrew-sh.Cheng" <andrew-sh.cheng@xxxxxxxxxxxx>
>
> This adds dt-binding documentation of cci devfreq
> for Mediatek MT8183 SoC platform.
>
> Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@xxxxxxxxxxxx>
> ---
> .../bindings/devfreq/mt8183-cci-devfreq.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt
>
> diff --git a/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt
> new file mode 100644
> index 0000000..e2b61cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt
> @@ -0,0 +1,19 @@
> +* Mediatek CCI frequency device
You have to add more detailed what to do on this driver.
Also, please add the full alphabet for CCI.
> +
> +Required properties:
> +- compatible: should contain "mediatek,mt8183-cci" for cci devfreq
Usually, dt-binding document only specifies h/w information
and how to bind device. 'devfreq' is the word of linux-side.
It means that 'devfreq' cannot indicate the any h/w device.
You should use the h/w device information and word of CCI for writing
the dt-binding document without linux-side word like devfreq.
For example,
- cci devfreq -> frequency scaling of CCI
> +
Remove unneeded blank line.
> +- clocks: for cci devfreq
ditto of 'devfreq' word.
> +
ditto of blank line
> +- clock-names: for cci devfreq driver to reference
ditto of 'devfreq' word.
> +
ditto of blank line
> +- operating-points-v2: for cci devfreq opp table
ditto of 'devfreq' word.
> +
> +Example:
> + cci: cci {
> + compatible = "mediatek,cci";
> + clocks = <&apmixedsys CLK_APMIXED_CCIPLL>;
> + clock-names = "cci_clock";
> + operating-points-v2 = <&cci_opp>;
> + };
> +
>
This document is missing the 'regulator' property. Please add it
--
Best Regards,
Chanwoo Choi
Samsung Electronics
