On Fri, Feb 08, 2019 at 11:53:41AM +0000, Mark Brown wrote: > On Thu, Feb 07, 2019 at 05:57:53PM +0100, Johan Hovold wrote: > > > +++ b/sound/soc/codecs/msm8916-wcd-analog.c > > @@ -1,3 +1,8 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2016, The Linux Foundation. All rights reserved. > > + */ > > Please use a C++ comment for the whole thing so it looks more consistent > with the rest of ASoC (and a bit neater in general). Ah, yes, that makes sense for consistency since you've already enforced that style. And while I don't think the all-c++-comment headers look better in general, for the single copyright statement case it's not too bad. v2 under way. Johan
