Dear Mark Thanks for the suggestion, will update accordingly. On Tue, Mar 18, 2014 at 8:34 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: > On Tue, Mar 18, 2014 at 08:40:15AM +0000, Zhangfei Gao wrote: >> This patch adds the Device Tree bindings for the Hisilicon hip04 >> Ethernet controller, including 100M / 1000M controller. >> >> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx> >> --- >> .../bindings/net/hisilicon-hip04-net.txt | 74 ++++++++++++++++++++ >> 1 file changed, 74 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/hisilicon-hip04-net.txt >> >> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hip04-net.txt b/Documentation/devicetree/bindings/net/hisilicon-hip04-net.txt >> new file mode 100644 >> index 0000000..c918f08 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/hisilicon-hip04-net.txt >> @@ -0,0 +1,74 @@ >> +Hisilicon hip04 Ethernet Controller >> + >> +* Ethernet controller node >> + >> +Required properties: >> +- compatible: should be "hisilicon,hip04-mac". >> +- reg: address and length of the register set for the device. >> +- interrupts: interrupt for the device. >> +- port: ppe port number connected to the controller: range from 0 to 31. > > ppe? > > Will there ever be more than one ppe? If so, describing the linkage to > the ppe with a phandle + args approach is preferable. > >> +- speed: 100 (100M) or 1000 (1000M). > > Can you not query this from the hardware? Will remove speed. > >> +- id: should be different and fe should be 0. > > This description is useless. > > What is this for, and why does this need to be in the dt? What is "fe"? Use alias instead. > >> + >> +Optional Properties: >> +- phy-handle : the phandle to a PHY node >> + >> + >> +* Ethernet ppe node: control rx & tx fifos of all ethernet controllers >> + >> +Required properties: >> +- compatible: should be "hisilicon,hip04-ppebase". > > Why "ppebase" rather than "ppe"? > >> +- reg: address and length of the register set for the node. > > s/node/device/ OK. Thanks -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
