Hello Lee, Thanks for the reviews! On Thu, Feb 07, 2019 at 02:04:18PM +0000, Lee Jones wrote: > On Thu, 07 Feb 2019, Matti Vaittinen wrote: > > > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED > > drivers) and 4 GPIO pins which can be configured for I/O or > > as interrupt sources withe configurable trigger levels. > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > --- > > .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 102 +++++++++++++++++++++ > > 1 file changed, 102 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > new file mode 100644 > > index 000000000000..f80be7e40184 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > @@ -0,0 +1,102 @@ > > +* ROHM BD70528 Power Management Integrated Circuit bindings > > + > > +BD70528MWV is an ultra-low Iq general purpose single-chip power management IC > > What's an Iq? http://www.ti.com/lit/an/slyt412/slyt412.pdf Iq is an abbreviation of quiescet current. Do you think it's worth writing the whole words instead of an abbreviation? Thanks for the rest of the corrections, I'll fix them in next version. Br, Matti Vaittinen
