Moro Kalle, On Wed, Feb 06, 2019 at 08:31:32PM +0200, Kalle Valo wrote: > Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> writes: > > > Patch series introducing support for ROHM BD70528 PMIC > > > > Please note that patch 1 breaks compilation without patches 2 and 3 > > Knowing the bd718x7 driver is already in upstream, it might be good > > if this change went through single tree, right? > > That would break bisect, please avoid that. So after applying patches > from a patchset one by one the compilation should always succeed. Right. Thanks for the reminder. Mark did also ask about this earlier. This split was originally done to clearly point out changes impacting in-tree drivers on separate subsystems/trees (mfd, clk and regulators). But you are right, these should be squashed before applying. I have now received acks from Mark and Stephen so I guess I can squash them even though Lee has not yet commented anything yet. I guess that 7 previous versions do already clearly enough point out these changes =) I will squash them in next version. Thanks for the reminder. > > -- > Kalle Valo -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
