Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Mark Brown,

On 03/20/2014 09:47 PM, Mark Brown wrote:
On Thu, Mar 20, 2014 at 10:37:53AM +0800, Bo Shen wrote:

For this, in my mind, I think we need add following parameters in DT.
1. sysclk_src_from_fll --> we need do nothing.

No, how would this work?  If nothing else the FLL needs configuration.

Only configure it in machine driver. Then no DT operation.

2. sysclk_src_from_mclk
    2.1 use_external_xtal --> we need clock_frequency
    2.2 !use_external_xtal --> we need retrieve clock and clock_frequency.

No, this is all handled in the clock binding.  If there's a fixed rate
clock the device tree should have a fixed rate clock provided.

Does this acceptable? Or any other better suggestion for this?

Just have the device tree describe the hardware and provide a way of
specifying an optional MCLK.


I will implement an RFC patch, please help review it. Thanks.

Best Regards,
Bo Shen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux