On Thu, Mar 20, 2014 at 8:57 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Tue, Mar 18, 2014 at 04:47:36PM -0700, Tim Kryger wrote: >> On Tue, Mar 18, 2014 at 2:52 PM, Thierry Reding >> <thierry.reding@xxxxxxxxx> wrote: >> > On Wed, Mar 12, 2014 at 01:15:43PM -0700, Tim Kryger wrote: >> >> + tristate "Kona PWM support" >> >> + depends on ARCH_BCM_MOBILE >> >> + default y >> > >> > No "default y", please. >> >> Even though it depends on ARCH_BCM_MOBILE? It seems like a reasonable >> default. > > Well, that's only true until somebody decides to turn that dependency > into something like: > > depends on ARCH_BCM_MOBILE || COMPILE_TEST Do you expect someone would actually make such a change? > >> These SoCs target mobile phones which almost always have a backlight >> controlled by the PWM. > > And you can easily turn it on in bcm_defconfig and/or multi_v7_defconfig > if you want it enabled "by default". Except that is not what default means. Having a sensible default value in the Kconfig is convenient and enables savedefconfig to create minimal configuration files. Are you firmly opposed to this? Thanks Again, Tim -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
