Hi Mark,
On Wed, 2019-01-30 at 15:18 +0000, Mark Brown wrote:
> On Wed, Jan 30, 2019 at 05:18:10PM +0800, Hsin-Hsiung Wang wrote:
>
> > +static const struct of_device_id mt6358_of_match[] = {
> > + { .compatible = "mediatek,mt6358-regulator", },
> > + { /* sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, mt6358_of_match);
>
> There should be no need for a separate compatbile string here - we
> aren't describing the hardware any more than we already did with the
> parent node for the MFD, we're describing how Linux currently splits the
> software that controls the hardware up. Just have the MFD instantiate
> the regulator driver when it probes.
>
> Otherwise this driver looks very good and clean.
Thanks for your suggestion.
It sounds pretty good and I will modify it in next patch series.
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
