On 29/01/2019 16:42, Lucas Stach wrote:
Hi Carlo,
Hi Lucas,
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -516,6 +516,19 @@
};
};
+ spi0: spi@30bb0000 {
30bb0000 is part of the AIPS3 bus address space, so please move this to
the correct location within this bus node.
The problem is that the "QuadSPI-memory" region doesn't fall within the
memory range of the AIPS3 bus, so the devm_ioremap_resource is failing
when moving the node there.
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,imx7d-qspi";
Please add a "fsl,imx8mq-qspi" compatible here, as was done with all
the other nodes in this file, so we can match this in the driver should
the need arise.
This is odd since at least for the AmLogic SoCs we are going exactly in
the opposite direction where we avoid to add unnecessary compatibles if
that's not strictly required.
+ reg = <0x30bb0000 0x10000>, <0x08000000 0x10000000>;
+ reg-names = "QuadSPI", "QuadSPI-memory";
+ interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_QSPI_ROOT>,
+ <&clk IMX8MQ_CLK_QSPI_ROOT>;
Please align the second clock reference, as is done for all other
peripheral nodes in this file.
I'll do.
Cheers,
--
Carlo Caione
