On Mon, 2019-01-28 at 16:25 -0800, Dmitry Torokhov wrote: > On Tue, Dec 18, 2018 at 09:40:02AM +0100, Richard Leitner wrote: > > Some of the #defined register values are one-bit flags. Convert them to > > use the BIT(x) macro instead of 1 byte hexadecimal values. This improves > > readability and clarifies the intent. > > > > Signed-off-by: Richard Leitner <richard.leitner@xxxxxxxxxxx> > > Applied, thank you. Not so sure this should be applied. > > diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c [] > > @@ -46,7 +47,7 @@ [] > > /* bits for I2C_REG_IRQSRC */ > > -#define IRQ_PENTOUCH_TOUCHCONVDONE 0x08 > > -#define IRQ_PENRELEASE 0x04 > > +#define IRQ_PENTOUCH_TOUCHCONVDONE BIT(7) > > +#define IRQ_PENRELEASE BIT(6) Shouldn't this be BIT(3) and BIT(2) or did you mean to change the values too? If so, this change should be noted in the commit message.
