Re: [PATCH v2 1/2] arm64: dts: imx8mq-evk: add missing MDIO / PHY nodes

[Andrew Lunn <andrew@xxxxxxx>]

On Mon, Jan 28, 2019 at 09:52:11AM +0000, Carlo Caione wrote:
> Populate the fec1 node with the missing MDIO and PHY entries.
> 
> Signed-off-by: Carlo Caione <ccaione@xxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index 64acccc4bfcb..2641f777d0bb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -37,7 +37,18 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_fec1>;
>  	phy-mode = "rgmii-id";
> +	phy-handle = <&ethphy0>;
>  	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@0 {
> +			compatible = "ethernet-phy-ieee802.3-c22";

Hi Carlo

This compatible string is optional. But having it does not harm
anything.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew