Hi Zhou, On Mon, Jan 28, 2019 at 10:23 AM Zhou Yanjie <zhouyanjie@xxxxxxxx> wrote: > Add support for probing the 8250_ingenic driver on the > X1000 Soc from Ingenic. > > Signed-off-by: Zhou Yanjie <zhouyanjie@xxxxxxxx> Thanks for your patch! > --- a/drivers/tty/serial/8250/8250_ingenic.c > +++ b/drivers/tty/serial/8250/8250_ingenic.c > @@ -145,6 +145,10 @@ EARLYCON_DECLARE(jz4780_uart, ingenic_early_console_setup); > OF_EARLYCON_DECLARE(jz4780_uart, "ingenic,jz4780-uart", > ingenic_early_console_setup); > > +EARLYCON_DECLARE(x1000_uart, ingenic_early_console_setup); > +OF_EARLYCON_DECLARE(x1000_uart, "ingenic,x1000-uart", > + ingenic_early_console_setup); As of commit 2eaa790989e03900 ("earlycon: Use common framework for earlycon declarations") it is no longer needer to specify both EARLYCON_DECLARE() and OF_EARLYCON_DECLARE(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds