On 1/26/19 12:17 PM, Jonathan Cameron wrote:
On Mon, 21 Jan 2019 18:04:27 -0800
Martin Kelly <martin@xxxxxxxxxxxxxxxx> wrote:
From: Martin Kelly <martin@xxxxxxxxxxxxxxxx>
Add interrupt support for the data ready signal on the BMI160, which fires
an interrupt whenever new accelerometer/gyroscope data is ready to read.
Signed-off-by: Martin Kelly <martin@xxxxxxxxxxxxxxxx>
[snip]
That seems unlikely. Why on a rising trigger are we setting a flag
that is named to imply it sets level triggering?
Looking again, I see that the code is right but the names/comment were
wrong. In v3, I renamed BMI160_LEVEL_TRIGGERED to BMI160_EDGE_TRIGGERED,
as the default is actually level-triggered active-low. The datasheet (p
63) has a sentence:
‘1’ (‘0’) is edge (level) triggered for INT1 pin
which I read backwards.
