Hi, fugang.duan@xxxxxxxxxxxxx wrote: > From: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx> > Data: Wednesday, March 19, 2014 9:09 PM > > >To: Dmitry Torokhov; Duan Fugang-B38611; Grant Likely; Henrik Rydberg; Ian > >Campbell; Jingoo Han; Kumar Gala; Mark Rutland; Pawel Moll; Rob Herring; Rob > >Landley; Sachin Kamat; devicetree@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; > >linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Simon Budig; Lothar > >Waßmann > >Subject: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support > > > > No need to quote the mail headers here. [...] > >diff --git a/drivers/input/touchscreen/edt-ft5x06.c > >b/drivers/input/touchscreen/edt-ft5x06.c > >index 7b4470d..257a1c8 100644 > >--- a/drivers/input/touchscreen/edt-ft5x06.c > >+++ b/drivers/input/touchscreen/edt-ft5x06.c > >@@ -33,6 +33,7 @@ > > #include <linux/debugfs.h> > > #include <linux/slab.h> > > #include <linux/gpio.h> > >+#include <linux/of_gpio.h> > > #include <linux/input/mt.h> > > #include <linux/input/edt-ft5x06.h> > > > [...] > >+#ifdef CONFIG_OF > >+static int edt_ft5x06_i2c_ts_probe_dt(struct device *dev, > >+ struct edt_ft5x06_ts_data *tsdata) > >+{ > >+ struct device_node *np = dev->of_node; > >+ > >+ if (!np) > >+ return -ENODEV; > Don't need to check the device node valid. If the device node is not existed, the driver don't run probe. > Perfectly right. I'll drop this in the next version. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html