On 2019-01-24 02:26, Aaro Koskinen wrote: > Hi, > > On Wed, Jan 23, 2019 at 08:05:11PM +0800, liaoweixiong wrote: >> Why should we need pstore_block? >> 1. Most embedded intelligent equipment have no persistent ram, which >> increases costs. We perfer to cheaper solutions, like block devices. >> In fast, there is already a sample for block device logger in driver >> MTD (drivers/mtd/mtdoops.c). > > I think you should add a patch for some actual block device using this > new framework to show that it can work. What HW you think would be > using things? > I will try to add a patch. Actually, I have implemented it on allwinner platform, but unfortunately these codes are unsuitable to submit to upper stream. In addition, there is already a sample for pstore/blk on patch 3 of version 7. It names blkoops. Blkoops is suitable for most block device as what it need is just a path of a partition. We can use it to test most of features but panic. > A. > -- liaoweixiong