Hi, On Thu, Jan 10, 2019 at 06:40:02PM +0100, Lubomir Rintel wrote: > The global variables for private data are not too nice. I'd like some > more, and that would clutter the global name space even further. > > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> [...] > - ret = device_create_bin_file(&olpc_bat->dev, &olpc_bat_eeprom); > + ret = device_create_bin_file(&data->olpc_bat->dev, &olpc_bat_eeprom); > if (ret) > goto eeprom_failed; > > - ret = device_create_file(&olpc_bat->dev, &olpc_bat_error); > + ret = device_create_file(&data->olpc_bat->dev, &olpc_bat_error); > if (ret) > goto error_failed; Could you create another patch, that converts this to use the functionality introduced in cef8fe6a382c? I missed the device_create_* functions and you can actually test the change. An example for such a conversion would be "711aebcfe3ba" (ds2781). P.S.: This is not mandatory for applying this patchset of course. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
