Hello Simon, Thank you for your feedback! > From: Simon Horman <horms@xxxxxxxxxxxx> > Sent: 23 January 2019 11:38 > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@xxxxxxxxxxx> > > > > > > Thanks, > > > > > > This looks fine to me but I will wait to see if there are other reviews > > > before applying. > > > > > > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > > > Thanks again, applied for v5.1. > > Sorry, I was a little hasty there. > > This patch depends on the presence of R8A774A1_CLK_CANFD which > (rightly) is added in a different patch in this series which is to > go upstream via a different tree. > > I have dropped this patch for now. I think there are two solution to this > problem. > > 1. Provide a version of this patch which uses a numeric index instead of > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > Yeah, my personal preference is solution 2. Thanks, Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
